feat: add conversion api #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: deprecated Python 3.6 support in #100 |
fubuloubu
force-pushed
the
feat/conversion-api
branch
6 times, most recently
from
4fb4b2d to
a7313bd
Compare
fubuloubu
force-pushed
the
feat/conversion-api
branch
3 times, most recently
from
2c4e445 to
a80a3d6
Compare
fubuloubu
force-pushed
the
feat/conversion-api
branch
from
a80a3d6 to
88f7dc3
Compare
fubuloubu
force-pushed
the
feat/conversion-api
branch
from
90cc548 to
1d23f82
Compare
|
I was trying to verify it but I got the following error: |
|
I put a breakpoint at 83: |
|
I swapped the order of the two, does it work now? |
sabotagebeats
suggested changes
Jul 23, 2021
There was a problem hiding this comment.
@fubuloubu no i think it has to be int not "uint256"
I swapped the order of the two, does it work now?
In [1]: convert("1 Eth","int") == int(1e18)
---------------------------------------------------------------------------
Exception Traceback (most recent call last)
<ipython-input-1-0c519f26f9f1> in <module>
----> 1 convert("1 Eth","int") == int(1e18)
~/work/apeworx/ape/src/ape/managers/converters.py in convert(self, value, type)
83 if type not in self._converters:
84 converter_types = ", ".join(map(lambda t: t.__name__, self._converters))
---> 85 raise Exception(f"ABI Type '{type}' must be one of [{converter_types}]")
86
87 if self.is_type(value, type):
Exception: ABI Type 'int' must be one of [ChecksumAddress, bytes, int]
sabotagebeats
approved these changes
Jul 23, 2021
| unit=st.sampled_from(list(ETHER_UNITS.keys())), | ||
| ) | ||
| def test_ether_conversions(value, unit): | ||
| assert convert(value=f"{value} {unit}", type=int) == int(value * ETHER_UNITS[unit]) |
There was a problem hiding this comment.
this test looks right, and passes
|
@fubuloubu ok looks good to me as long as those caveats I listed above - to use syntax needs to be like |
fubuloubu
added a commit
that referenced
this pull request
Jul 24, 2021
* feat: add non-checksummed address converter (with warning) * refactor: use internal AddressType instead of ChecksumAddress * feat: add AddressAPI converter to address * refactor: add conversion manager dep to account manager * refactor: display accounts in repr * feat: added support for ether types in account calls * test: add tests for ether conversion fn * feat: add conversion for Ether units * feat: add ConversionAPI * fix: updates eth-account requirement in setup.py to fix breaking change from pull 103 (#107) Co-authored-by: Doggo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added support for argument conversions via API
fixes: #3
depends: #92How I did it
Added
ConversionManagerandConverterAPIHow to verify it
(In
ape console):Checklist